-
-
Notifications
You must be signed in to change notification settings - Fork 445
Check plugin updates only for Release build #3921
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🥷 Code experts: no user but you matched threshold 10 Jack251970 has most 👩💻 activity in the files. See details
Activity based on git-commit:
Knowledge based on git-blame: ✨ Comment |
Be a legend 🏆 by adding a before and after screenshot of the changes you made, especially if they are around UI/UX. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.
I've seen the update tip when using local release build on dev. Should we check whether running dev plugin to solve this issue? |
I think this solution is simple and it will not break anything (We can still check plugin updates manually in plugin update page). If we want to check dev plugins, there should be more logic which I think is unnecessary. |
I think what Raptor is saying is that when you do a 'Release' build locally this issue still exists. Problem is I am assuming everyone uses different IDEs for flow e.g. vscode, rider, vs studio etc, we don't have a uniform way of upping the plugin versions during the build process, unless we run a dedicated build script. We can still solve this by creating:
I personally think it's a minor annoyance update message that can be ignored, so up to you guys if you think it's worth implementing. For now this change is good as well that solves the debug environment issue. |
Check plugin updates only for Release
Follow on with #3827.
When we start Flow on Debug configuration, Flow will pop up this message every time it starts since all pre-released plugins are in version 1.0.0. So let us check plugin updates only for release to remove that annoying message during Flow startup to improve development experience.